fix(ai): harden SSE stream error handling
- make chat SSE timeout configurable and default to 10 minutes - stop upstream stream client when emitter send fails - add full exception logging and frontend error notification on stream failures
This commit is contained in:
@@ -8,6 +8,9 @@ import com.easyagents.core.model.chat.StreamResponseListener;
|
||||
import com.easyagents.core.model.chat.response.AiMessageResponse;
|
||||
import com.easyagents.core.model.client.StreamContext;
|
||||
import com.easyagents.core.prompt.MemoryPrompt;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
import tech.easyflow.common.util.StringUtil;
|
||||
import tech.easyflow.core.chat.protocol.ChatDomain;
|
||||
import tech.easyflow.core.chat.protocol.ChatEnvelope;
|
||||
import tech.easyflow.core.chat.protocol.ChatType;
|
||||
@@ -15,7 +18,6 @@ import tech.easyflow.core.chat.protocol.MessageRole;
|
||||
import tech.easyflow.core.chat.protocol.payload.ErrorPayload;
|
||||
import tech.easyflow.core.chat.protocol.sse.ChatSseEmitter;
|
||||
|
||||
import java.io.IOException;
|
||||
import java.util.LinkedHashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
@@ -23,6 +25,8 @@ import java.util.concurrent.atomic.AtomicBoolean;
|
||||
|
||||
public class ChatStreamListener implements StreamResponseListener {
|
||||
|
||||
private static final Logger LOG = LoggerFactory.getLogger(ChatStreamListener.class);
|
||||
|
||||
private final String conversationId;
|
||||
private final ChatModel chatModel;
|
||||
private final MemoryPrompt memoryPrompt;
|
||||
@@ -51,6 +55,10 @@ public class ChatStreamListener implements StreamResponseListener {
|
||||
@Override
|
||||
public void onMessage(StreamContext context, AiMessageResponse aiMessageResponse) {
|
||||
try {
|
||||
if (completed.get() || sseEmitter.isClosed()) {
|
||||
stopStreamClient(context, "emitter_closed_before_message", null);
|
||||
return;
|
||||
}
|
||||
AiMessage aiMessage = aiMessageResponse.getMessage();
|
||||
if (aiMessage == null) {
|
||||
return;
|
||||
@@ -81,7 +89,12 @@ public class ChatStreamListener implements StreamResponseListener {
|
||||
|
||||
}
|
||||
} catch (Exception e) {
|
||||
throw new RuntimeException(e);
|
||||
LOG.error("Chat stream onMessage failed, conversationId={}, message={}, exception={}",
|
||||
conversationId, e.getMessage(), e.toString(), e);
|
||||
if (completed.compareAndSet(false, true)) {
|
||||
sendSystemError(sseEmitter, "流式响应异常，请重试", e);
|
||||
}
|
||||
stopStreamClient(context, "on_message_exception", e);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -89,15 +102,17 @@ public class ChatStreamListener implements StreamResponseListener {
|
||||
public void onStop(StreamContext context) {
|
||||
// 仅当canStop为true（最后一次无后续工具调用的响应）时，执行业务逻辑
|
||||
if (this.canStop && completed.compareAndSet(false, true)) {
|
||||
System.out.println("onStop");
|
||||
if (context.getThrowable() != null) {
|
||||
sendSystemError(sseEmitter, context.getThrowable().getMessage());
|
||||
sendSystemError(sseEmitter, context.getThrowable().getMessage(), context.getThrowable());
|
||||
return;
|
||||
}
|
||||
memoryPrompt.addMessage(context.getFullMessage());
|
||||
ChatEnvelope<Map<String, String>> chatEnvelope = new ChatEnvelope<>();
|
||||
chatEnvelope.setDomain(ChatDomain.SYSTEM);
|
||||
sseEmitter.sendDone(chatEnvelope);
|
||||
boolean doneSent = sseEmitter.sendDone(chatEnvelope);
|
||||
if (!doneSent) {
|
||||
LOG.warn("sendDone skipped because emitter is closed, conversationId={}", conversationId);
|
||||
}
|
||||
StreamResponseListener.super.onStop(context);
|
||||
}
|
||||
|
||||
@@ -105,13 +120,17 @@ public class ChatStreamListener implements StreamResponseListener {
|
||||
|
||||
@Override
|
||||
public void onFailure(StreamContext context, Throwable throwable) {
|
||||
if (throwable != null && completed.compareAndSet(false, true)) {
|
||||
throwable.printStackTrace();
|
||||
sendSystemError(sseEmitter, throwable.getMessage());
|
||||
if (throwable != null) {
|
||||
LOG.error("Chat stream onFailure, conversationId={}, message={}, exception={}",
|
||||
conversationId, throwable.getMessage(), throwable.toString(), throwable);
|
||||
}
|
||||
if (throwable != null && completed.compareAndSet(false, true)) {
|
||||
sendSystemError(sseEmitter, throwable.getMessage(), throwable);
|
||||
}
|
||||
stopStreamClient(context, "on_failure", throwable);
|
||||
}
|
||||
|
||||
private void sendChatEnvelope(ChatSseEmitter sseEmitter, String deltaContent, ChatType chatType) throws IOException {
|
||||
private void sendChatEnvelope(ChatSseEmitter sseEmitter, String deltaContent, ChatType chatType) {
|
||||
if (deltaContent == null || deltaContent.isEmpty()) {
|
||||
return;
|
||||
}
|
||||
@@ -126,21 +145,49 @@ public class ChatStreamListener implements StreamResponseListener {
|
||||
deltaMap.put("delta", deltaContent);
|
||||
chatEnvelope.setPayload(deltaMap);
|
||||
|
||||
sseEmitter.send(chatEnvelope);
|
||||
boolean sent = sseEmitter.send(chatEnvelope);
|
||||
if (!sent) {
|
||||
throw new IllegalStateException("SSE emitter has already completed while sending chat envelope");
|
||||
}
|
||||
}
|
||||
|
||||
public void sendSystemError(ChatSseEmitter sseEmitter,
|
||||
String message) {
|
||||
String message,
|
||||
Throwable throwable) {
|
||||
String errorMessage = StringUtil.hasText(message) ? message : "系统繁忙，请稍后重试";
|
||||
if (throwable != null) {
|
||||
LOG.error("sendSystemError, conversationId={}, message={}, exception={}",
|
||||
conversationId, throwable.getMessage(), throwable.toString(), throwable);
|
||||
}
|
||||
ChatEnvelope<ErrorPayload> envelope = new ChatEnvelope<>();
|
||||
ErrorPayload payload = new ErrorPayload();
|
||||
payload.setMessage(message);
|
||||
payload.setMessage(errorMessage);
|
||||
payload.setCode("SYSTEM_ERROR");
|
||||
payload.setRetryable(false);
|
||||
envelope.setPayload(payload);
|
||||
envelope.setDomain(ChatDomain.SYSTEM);
|
||||
envelope.setType(ChatType.ERROR);
|
||||
sseEmitter.sendError(envelope);
|
||||
boolean sent = sseEmitter.sendError(envelope);
|
||||
if (!sent) {
|
||||
LOG.warn("sendSystemError skipped because emitter is closed, conversationId={}", conversationId);
|
||||
}
|
||||
sseEmitter.complete();
|
||||
}
|
||||
|
||||
private void stopStreamClient(StreamContext context, String reason, Throwable source) {
|
||||
try {
|
||||
if (context != null && context.getClient() != null) {
|
||||
context.getClient().stop();
|
||||
LOG.warn("Stopped stream client, conversationId={}, reason={}", conversationId, reason);
|
||||
}
|
||||
} catch (Exception stopEx) {
|
||||
LOG.error("Stop stream client failed, conversationId={}, reason={}, message={}, exception={}",
|
||||
conversationId, reason, stopEx.getMessage(), stopEx.toString(), stopEx);
|
||||
if (source != null) {
|
||||
LOG.error("Original stream failure, conversationId={}, message={}, exception={}",
|
||||
conversationId, source.getMessage(), source.toString(), source);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -4,7 +4,8 @@ import com.easyagents.core.memory.DefaultChatMemory;
|
||||
import com.easyagents.core.message.*;
|
||||
import com.alibaba.fastjson.JSON;
|
||||
import com.alibaba.fastjson.serializer.SerializerFeature;
|
||||
import org.springframework.web.servlet.mvc.method.annotation.SseEmitter;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
import tech.easyflow.ai.entity.BotMessage;
|
||||
import tech.easyflow.core.chat.protocol.ChatDomain;
|
||||
import tech.easyflow.core.chat.protocol.ChatEnvelope;
|
||||
@@ -12,7 +13,6 @@ import tech.easyflow.core.chat.protocol.ChatType;
|
||||
import tech.easyflow.core.chat.protocol.MessageRole;
|
||||
import tech.easyflow.core.chat.protocol.sse.ChatSseEmitter;
|
||||
|
||||
import java.io.IOException;
|
||||
import java.math.BigInteger;
|
||||
import java.util.ArrayList;
|
||||
import java.util.HashMap;
|
||||
@@ -23,6 +23,8 @@ import java.util.stream.Collectors;
|
||||
|
||||
public class DefaultBotMessageMemory extends DefaultChatMemory {
|
||||
|
||||
private static final Logger LOG = LoggerFactory.getLogger(DefaultBotMessageMemory.class);
|
||||
|
||||
private final ChatSseEmitter sseEmitter;
|
||||
|
||||
private final List<Map<String, String>> messages;
|
||||
@@ -72,7 +74,13 @@ public class DefaultBotMessageMemory extends DefaultChatMemory {
|
||||
if (dbMessage.getRole().equals(MessageRole.USER.getValue())) {
|
||||
messages.remove(messages.size() - 1);
|
||||
}
|
||||
sseEmitter.sendMessageNeedSave(chatEnvelope);
|
||||
boolean sent = sseEmitter.sendMessageNeedSave(chatEnvelope);
|
||||
if (!sent) {
|
||||
IllegalStateException e = new IllegalStateException("SSE emitter has already completed when sending needSaveMessage");
|
||||
LOG.error("sendMessageNeedSave failed, role={}, message={}, exception={}",
|
||||
dbMessage.getRole(), e.getMessage(), e.toString(), e);
|
||||
throw e;
|
||||
}
|
||||
messages.add(res);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user